[ACTP] PAR: warn on misconfigured rshell allowed_paths entries#49948
[ACTP] PAR: warn on misconfigured rshell allowed_paths entries#49948julesmcrt wants to merge 1 commit intojules.macret/Q/rshell/01-fix-bugsfrom
Conversation
Two advisory warnings at config load surface misconfigurations that would otherwise silently fail at task execution: - Backslash entries: the operator-side allow-list is forward-slash only (Linux form). Windows-native paths never match the backend's Linux-style entries. - Non-directory entries: rshell's sandbox is built on os.Root, which only accepts directory handles. File entries get silently dropped at runner creation, producing permission-denied for every open with no operator-facing message. Both warnings are advisory — entries still flow through to the handler; the warnings make the silent-failure modes observable in agent logs.
|
🎯 Code Coverage (details) 🔗 Commit SHA: da001c9 | Docs | Datadog PR Page | Give us feedback! |
Files inventory check summaryFile checks results against ancestor c1888d89: Results for datadog-agent_7.80.0~devel.git.264.da001c9.pipeline.109970833-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
21 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: b15fe93 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.57 | [+1.55, +7.58] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +4.57 | [+1.55, +7.58] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +1.65 | [+1.39, +1.90] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.80 | [+0.64, +0.96] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.69 | [+0.50, +0.87] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.24 | [+0.19, +0.29] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.18 | [+0.13, +0.23] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.13 | [+0.10, +0.17] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.11 | [+0.01, +0.21] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.10 | [-0.29, +0.49] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.08 | [-0.16, +0.32] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.07 | [-0.37, +0.50] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.06 | [-0.45, +0.57] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.04 | [-0.06, +0.14] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.03 | [-0.13, +0.19] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.02 | [-0.19, +0.24] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.02 | [-0.03, +0.06] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.01 | [-0.21, +0.19] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -0.12 | [-1.09, +0.85] | 1 | Logs bounds checks dashboard |
| ➖ | otlp_ingest_logs | memory utilization | -0.43 | [-0.54, -0.32] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.76 | [-0.83, -0.69] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.79 | [-0.97, -0.61] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.30 | [-1.48, -1.12] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 691 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 244.80MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 681 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.16GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.21GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.17GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.18GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 141.00MiB ≤ 147MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 ≤ 4 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 465.97MiB ≤ 495MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 172.55MiB ≤ 195MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 344.83 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 376.01MiB ≤ 430MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
What does this PR do?
Adds two advisory warnings at PAR config load that surface common
allowed_pathsmisconfigurations which would otherwise silently fail at task execution:os.Root, which only accepts directory handles. File entries get silently dropped at runner creation, producing permission-denied for every open.Both warnings are advisory — entries still flow through to the handler; the warnings make the silent-failure modes observable in agent logs.
Stacked on top of #49945 (PR1 in the split)
This is PR2 of 4 splitting #49825. Base: PR1 branch. Will retarget to
mainafter PR1 lands.Describe how you validated your changes
transform_test.goverify that backslash and non-directory entries flow to the handler unchanged (the warnings are side effects).pkg/privateactionrunner/adapters/configpass; linter clean.🤖 Generated with Claude Code