Skip to content

[Backport 7.79.x] Bump rshell dependency from v0.0.13 to v0.0.14 (#49958)#50110

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.79.xfrom
matthew.deguzman/backport-49958-7.79.x
Apr 29, 2026
Merged

[Backport 7.79.x] Bump rshell dependency from v0.0.13 to v0.0.14 (#49958)#50110
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into7.79.xfrom
matthew.deguzman/backport-49958-7.79.x

Conversation

@matt-dz
Copy link
Copy Markdown
Contributor

@matt-dz matt-dz commented Apr 29, 2026

Backport of #49958 to 7.79.x.

What does this PR do?

  • Bumps github.com/DataDog/rshell from v0.0.13 to v0.0.14. No call-site changes.

Motivation

  • v0.0.13..v0.0.14 contains a single commit, DataDog/rshell#200, which adds an opt-in interp.WarningsWriter(io.Writer) option and a Runner.Warnings() []string accessor. Today's PAR rshell handler does not pass either, so behaviour is byte-for-byte unchanged: sandbox warnings continue to fall back to r.stderr, which is where the handler already routes them.
  • Backporting keeps 7.79.x aligned with main so the follow-up PR wiring runner.Warnings() into RunCommandOutputs.SandboxWarnings can be cherry-picked cleanly without go.mod/go.sum noise.

Describe how you validated your changes

  • Cherry-picked e083f5b19df2121690b8f9924fae312468bc4cb1 from main. Conflict in go.sum (expected — branch had drifted on unrelated deps); resolved by keeping the 7.79.x baseline and running dda inv tidy, which reconciled it to swap only the DataDog/rshell entries from v0.0.13 → v0.0.14.
  • git diff confirms only go.mod, go.sum (rshell entries only), and the new release note changed.

Additional Notes

🤖 Generated with Claude Code

)

- Bumps `github.com/DataDog/rshell` from `v0.0.13` to `v0.0.14`. No call-site changes.

- v0.0.13..v0.0.14 contains a single commit, [DataDog/rshell#200](DataDog/rshell#200), which adds an opt-in `interp.WarningsWriter(io.Writer)` option and a `Runner.Warnings() []string` accessor. Today's PAR rshell handler does not pass either, so behaviour is byte-for-byte unchanged: sandbox warnings continue to fall back to `r.stderr`, which is where the handler already routes them.
- This bump lands in isolation so the follow-up PR — wiring the new accessor into `RunCommandOutputs.SandboxWarnings` to fix [DataDog/rshell#191](DataDog/rshell#191) — is a clean, reviewable diff with no `go.mod`/`go.sum` noise.

(cherry picked from commit e083f5b)
@dd-octo-sts dd-octo-sts Bot added the internal Identify a non-fork PR label Apr 29, 2026
@github-actions github-actions Bot added the short review PR is simple enough to be reviewed quickly label Apr 29, 2026
@matt-dz matt-dz added qa/done QA done before merge and regressions are covered by tests team/action-platform labels Apr 29, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 462c62ceb8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

---
enhancements:
- |
Bump ``rshell`` to v0.0.14.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document the rshell shortcut hardening

The upstream v0.0.13..v0.0.14 diff is not just a warnings API bump: it also includes the rshell change that treats $(<file) as an implicit cat and blocks it unless rshell:cat is in allowedCommands. When a PAR runCommand script currently relies on that shortcut without allowing rshell:cat, this bump turns the task into a blocked-command failure, so a release note that only says “Bump rshell” under enhancements gives operators/backend allowlist owners no migration signal. Please mention the new rshell:cat requirement/security hardening here, or categorize it under security.

Useful? React with 👍 / 👎.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Apr 29, 2026

Files inventory check summary

File checks results against ancestor 102c3cb3:

Results for datadog-agent_7.79.0~rc.3.git.15.462c62c.pipeline.110481187-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented Apr 29, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 86536689-615b-4ffc-bdb0-1325b4418c52

Baseline: 102c3cb
Comparison: 462c62c
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.35 [-4.29, +1.59] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +2.17 [+1.94, +2.41] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.87 [-0.76, +2.50] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.49 [+0.31, +0.68] 1 Logs
ddot_metrics_sum_delta memory utilization +0.48 [+0.31, +0.65] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.47 [+0.29, +0.66] 1 Logs
ddot_logs memory utilization +0.35 [+0.28, +0.41] 1 Logs
otlp_ingest_logs memory utilization +0.28 [+0.18, +0.38] 1 Logs
file_tree memory utilization +0.15 [+0.09, +0.21] 1 Logs
otlp_ingest_metrics memory utilization +0.15 [-0.01, +0.31] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.09, +0.17] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.50, +0.57] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.20, +0.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.09, +0.10] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.41, +0.40] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.51, +0.36] 1 Logs
quality_gate_idle memory utilization -0.12 [-0.17, -0.06] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulative memory utilization -0.17 [-0.33, -0.02] 1 Logs
docker_containers_memory memory utilization -0.27 [-0.35, -0.19] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.30 [-0.36, -0.23] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.32 [-0.55, -0.10] 1 Logs
quality_gate_idle_all_features memory utilization -0.40 [-0.44, -0.36] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -1.35 [-4.29, +1.59] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 721 ≥ 26
docker_containers_memory memory_usage 10/10 275.02MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 711 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.79MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 4 = 4 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 504.58MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 209.93MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 369.60 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 414.67MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit fcd2043 into 7.79.x Apr 29, 2026
247 of 249 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the matthew.deguzman/backport-49958-7.79.x branch April 29, 2026 17:48
@github-actions github-actions Bot added this to the 7.79.0 milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/action-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants