[py] Implement backward-compatible increment/decrement#623
Merged
olivielpeau merged 1 commit intomasterfrom Sep 26, 2017
Merged
[py] Implement backward-compatible increment/decrement#623olivielpeau merged 1 commit intomasterfrom
increment/decrement#623olivielpeau merged 1 commit intomasterfrom
Conversation
Some experiments on existing checks have shown that sending these metrics with `count` was not working well in some of the checks (namely those that should be using `gauge` instead of `increment`/ `decrement`). Until we find a reasonable deprecation path to remove these methods, let's re-implement them fully for python checks (but keep the deprecation warnings).
olivielpeau
added
component/aggregator
[deprecated] team/agent-core
gmmeyer
approved these changes
Sep 26, 2017
Contributor
gmmeyer
left a comment
gmmeyer
left a comment
There was a problem hiding this comment.
I added one comment. It's a nit, feel free to merge or to address it and merge. I don't think we have time for nits right not 😃
| @@ -86,8 +86,8 @@ def __init__(self, *args, **kwargs): | |||
| self._deprecations = { | |||
| 'increment': [ | |||
Contributor
There was a problem hiding this comment.
Can you add decrement here too?
Member
Author
There was a problem hiding this comment.
actually here we log the deprecation warning once per check instance, whether increment or decrement is used in the check. Which is why there's only one entry in this dict.
The key in this dict could be renamed though (to counter maybe?) so that this behavior is more self-explanatory.
Let me know what you think, I'll go ahead and merge this but I can address your comments in a separate PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements backward-compatible
increment/decrement(i.e., with same behavior as agent5)Motivation
Some experiments on existing checks have shown that sending these
metrics with
AgentCheck.countwas not working well for some of the checks(namely those that should be using
gaugeinstead ofincrement/decrement).Until we find a reasonable deprecation path to remove these methods,
let's re-implement them fully for python checks (but keep the
deprecation warnings).
Additional notes
Follow-up to #297