Revert "[logs] Inherit source/service name in some cases (#7310)"#7345
Merged
Revert "[logs] Inherit source/service name in some cases (#7310)"#7345
Conversation
This reverts commit 8e56591.
prognant
added
changelog/no-changelog
sgnn7
approved these changes
Feb 3, 2021
olivielpeau
approved these changes
Feb 3, 2021
Member
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
Thanks! For future reference, more details on the rationale in this comment: #7310 (comment)
sergei-deliveroo
pushed a commit
to deliveroo/datadog-agent
that referenced
this pull request
Mar 24, 2021
…" (DataDog#7345) This reverts commit 8e56591.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit 8e56591.
#7310 introduced a change that is not consistent with the nominal integration config behaviour as they are supposed to be independent from each others.
Source/service may be manually set per log integration config if required Also a service may be set at pod level (using the label
tags.datadoghq.com/service),Motivation
Consistency across config.
Additional Notes
N/A
Describe your test plan
See #7176.
Using this logs config annotation:
Should :