Enhance the health framework to enqueue a deadline instead of an empty token#7829
Closed
Enhance the health framework to enqueue a deadline instead of an empty token#7829
Conversation
L3n41c
added
[deprecated] team/containers
changelog/no-changelog
L3n41c
force-pushed
the
lenaic/healthdeadline
branch
from
ceaccd7 to
46b3d28
Compare
clamoriniere
reviewed
Apr 8, 2021
clamoriniere
approved these changes
May 26, 2021
Member
Author
|
Already included in #7605. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The health framework works by enqueuing tokens in a channel and checking that the monitored components are regularly popping those tokens from the channel.
This change adds a deadline inside the token so that the monitored components can know when they absolutely need to come back popping elements from the health channel before being considered as stuck and being flagged as unhealthy.
Motivation
The deadline conveyed through the health channel token can then be used to build a
context.Contextthat can be cascaded down to the remote API calls like how it is done in #7605 in thead-servicecomponent, thead-config-provider-*component, thead-dockerlistenercomponent, thead-ecslistenercomponent, thead-kubeletlistenercomponent, etc.Additional Notes
Anything else we should know when reviewing?
Describe your test plan
This change cannot be tested alone. It’s part of #7605.