Log which collector had an error when pulling#7913
Merged
juliogreff merged 2 commits intomasterfrom Apr 16, 2021
Merged
Conversation
Previously, *Tagger.pull() would log only that an error happened, without specifying which collector the error was coming from. It isn't always obvious by the error itself (for instance, both the kube metadata and kubelet collectors can error out when getting the pod list from the kubelet), so now we prefix the log message with the collector name.
ahmed-mez
approved these changes
Apr 16, 2021
ahmed-mez
reviewed
Apr 16, 2021
Co-authored-by: Ahmed Mezghani <38987709+ahmed-mez@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, *Tagger.pull() would log only that an error happened,
without specifying which collector the error was coming from. It isn't
always obvious by the error itself (for instance, both the kube metadata
and kubelet collectors can error out when getting the pod list from the
kubelet), so now we prefix the log message with the collector name.
Describe your test plan
Blackhole traffic to the kubelet as below. Note that this only works if #7605 is merged, otherwise the tagger will hang and no error will be shown.
Check that the logs no longer look like this:
But instead look like this: