pkg/trace/{api,agent,pb}: introduce new client payload formats: TracerPayload & TraceChunk#9474
Closed
Barbayar wants to merge 5 commits intoDataDog:mainfrom
Closed
pkg/trace/{api,agent,pb}: introduce new client payload formats: TracerPayload & TraceChunk#9474Barbayar wants to merge 5 commits intoDataDog:mainfrom
Barbayar wants to merge 5 commits intoDataDog:mainfrom
Conversation
Collaborator
gbbr
reviewed
Oct 13, 2021
Contributor
gbbr
left a comment
There was a problem hiding this comment.
This is ok by me. Just a small curiosity around the conversion code.
Barbayar
commented
Oct 13, 2021
Barbayar
commented
Oct 20, 2021
Barbayar
commented
Oct 20, 2021
Barbayar
commented
Oct 20, 2021
Barbayar
commented
Oct 20, 2021
Barbayar
commented
Oct 20, 2021
Barbayar
commented
Oct 20, 2021
Barbayar
commented
Oct 20, 2021
gbbr
reviewed
Oct 22, 2021
64af360 to
753749c
Compare
Barbayar
commented
Oct 22, 2021
40bebf0 to
4d2271d
Compare
Barbayar
commented
Oct 25, 2021
4d2271d to
2d55eda
Compare
Barbayar
commented
Oct 25, 2021
Barbayar
commented
Oct 25, 2021
Barbayar
commented
Oct 26, 2021
Barbayar
commented
Oct 28, 2021
gbbr
reviewed
Oct 29, 2021
Contributor
gbbr
left a comment
There was a problem hiding this comment.
I've skimmed through the PR and left some comments. I'm not done, I'm yet to review the writer and some other bits, but I'm submitting them so you can get a head start.
fbd3c0c to
c74ac0d
Compare
gbbr
reviewed
Nov 1, 2021
gbbr
reviewed
Nov 1, 2021
gbbr
reviewed
Nov 2, 2021
gbbr
reviewed
Nov 2, 2021
gbbr
reviewed
Nov 2, 2021
5a4e693 to
db18b57
Compare
db18b57 to
2b61072
Compare
Contributor
|
Hi, As discussed offline, this PR changes are coupled to (and blocked by) related changes |
gbbr
reviewed
Nov 4, 2021
| import "span.proto"; | ||
| import "tracer_payload.proto"; | ||
|
|
||
| message TracePayload { |
Contributor
There was a problem hiding this comment.
I think we should call this AgentPayload, like in the RFC. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1. Updates the trace payload from agent to backend
Before:
After:
On backend, we would like to receive the payloads from the tracer as they are.
We also updated the payload from tracer to agent.
Before:
After:
2. Adds a new endpoint to receive the payload in new format from tracers
/v0.6/traces3. [serverless] Sets global tags at agent payload level instead of each spanwe can propagate the global tags on backendit helps the customers to reduce their traffic to us4. [container] Sets container tags at tracer payload level instead of each top level span
5. Removes redundant data
_dd.origintag from each spans as it's set at trace chunk level_sampling_priority_v1tag from each spans as it's set at trace chunk level6. Removed
Transactionsfrom the payload from agent to backendSpans in
Transactionsare a subset of spans in TracerPayloads. Instead of duplicating them inTransactions, we decided to keep them in TracerPayload, and just mark them with_dd.analyzed.Motivation
We would like receive the following information from the tracer to enrich our features.
To do that, we need to receive two level of structured data from tracer instead of
[][]*Span.Additional Notes
This PR doesn't contain any logical change. But, there will be 2 more PRs after this one gets merged.
trace-agentthat receives structured payload from tracesDescribe how to test your changes
As this PR doesn't introduce a new feature,
in the usual environment should enough for the test.
RFC
Checklist
changelog/no-changeloglabel has been applied.need-change/operatorandneed-change/helmlabels has been applied if applicable.team/..label has been applied, if known.Triagemilestone is set.Note: Adding GitHub labels is only possible for contributors with write access.