pkg/trace/obfuscate: fix bug where obfuscation fails for autovacuum sql text

[jmeunier28]

What does this PR do?

we are seeing query text like autovacuum: VACUUM ANALYZE fake.table fail obfuscation in the postgres integration check, and we want to be able to ingest things like this for DBM. It is failing due to the fact that it has a : followed by a space char. Because it has a :, the obfuscater assumes it is the beginning of a bind variable. Since the bindVar scanner code does not handle this case, obfuscation fails.

simply checking if the char in front of the : is a space will prevent this from happening

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe how to test your changes

Write here in detail how you have tested your changes
and instructions on how this should be tested in QA.

Describe or link instructions to set up environment
for testing, if the process requires more than just
running the agent on one of the supported platforms.

Checklist

• A release note has been added or the changelog/no-changelog label has been applied.
• The need-change/operator and need-change/helm labels has been applied if applicable.
• The appropriate team/.. label has been applied, if known.
• If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• The config template has been updated if applicable.

Note: Adding GitHub labels is only possible for contributors with write access.

[dujuku]

I agree with this direction, but one small comment about returning the correct token and not a bind var.

[dujuku]

👍

[gbbr]

You should add a release note for this. Please make sure to prefix it with APM: . Relevant links:

• How to add a release note: https://github.com/DataDog/datadog-agent/blob/main/docs/dev/contributing.md#reno
• Example release note: https://github.com/DataDog/datadog-agent/blob/main/releasenotes/notes/apm-credit-cards-obfuscation-918935ff76b3d897.yaml

[jmeunier28]

You should add a release note for this. Please make sure to prefix it with APM: . Relevant links:
How to add a release note: https://github.com/DataDog/datadog-agent/blob/main/docs/dev/contributing.md#reno
Example release note: https://github.com/DataDog/datadog-agent/blob/main/releasenotes/notes/apm-credit-cards-obfuscation-918935ff76b3d897.yaml

thanks for review, @gbbr! look OK now?

[gbbr]

Looks good! Thanks!