Skip to content

Skip 204 responses for validations #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
api-clients-generation-pipeline merged 2 commits into from
Apr 6, 2023
Merged

Skip 204 responses for validations #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbc63f5
Regenerate client from commit 9572acd2 of spec repo
Apr 6, 2023
de9336b
Merge branch 'master' into datadog-api-spec/generated/2132
api-clients-generation-pipeline[bot] Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.6.4",
"regenerated": "2023-04-05 14:45:40.505110",
"spec_repo_commit": "627d5fdd"
"regenerated": "2023-04-06 14:03:53.397002",
"spec_repo_commit": "9572acd2"
},
"v2": {
"apigentools_version": "1.6.4",
"regenerated": "2023-04-05 14:45:40.518187",
"spec_repo_commit": "627d5fdd"
"regenerated": "2023-04-06 14:03:53.409829",
"spec_repo_commit": "9572acd2"
}
}
}
2 changes: 1 addition & 1 deletion ...ources/cassettes/features/v2/Add_resource_to_Confluent_account_returns_OK_response.freeze
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2022-10-06T21:02:44.122Z
2023-04-06T14:00:35.438Z
18 changes: 9 additions & 9 deletions ...esources/cassettes/features/v2/Add_resource_to_Confluent_account_returns_OK_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"httpRequest": {
"body": {
"type": "JSON",
"json": "{\"data\":{\"attributes\":{\"api_key\":\"TestAddresourcetoConfluentaccountreturnsOKresponse1665090164\",\"api_secret\":\"test-api-secret\",\"resources\":[{\"id\":\"test-resource-id\",\"resource_type\":\"kafka\",\"tags\":[\"tag1\",\"tag2:val2\"]}],\"tags\":[\"tag1\",\"tag2:val2\"]},\"type\":\"confluent-cloud-accounts\"}}"
"json": "{\"data\":{\"attributes\":{\"api_key\":\"TestAddresourcetoConfluentaccountreturnsOKresponse1680789635\",\"api_secret\":\"test-api-secret\",\"resources\":[{\"id\":\"test-resource-id\",\"resource_type\":\"kafka\",\"tags\":[\"tag1\",\"tag2:val2\"]}],\"tags\":[\"tag1\",\"tag2:val2\"]},\"type\":\"confluent-cloud-accounts\"}}"
},
"headers": {},
"method": "POST",
Expand All @@ -12,7 +12,7 @@
"secure": true
},
"httpResponse": {
"body": "{\"data\":{\"attributes\":{\"api_key\":\"TestAddresourcetoConfluentaccountreturnsOKresponse1665090164\",\"resources\":[{\"id\":\"test-resource-id\",\"resource_type\":\"kafka\",\"tags\":[\"tag1\",\"tag2:val2\"]}],\"tags\":[\"tag1\",\"tag2:val2\"]},\"type\":\"confluent-cloud-accounts\",\"id\":\"l7mlzljfqc\"}}\n",
"body": "{\"data\":{\"type\":\"confluent-cloud-accounts\",\"attributes\":{\"tags\":[\"tag1\",\"tag2:val2\"],\"api_key\":\"TestAddresourcetoConfluentaccountreturnsOKresponse1680789635\",\"resources\":[{\"tags\":[\"tag1\",\"tag2:val2\"],\"resource_type\":\"kafka\",\"id\":\"test-resource-id\"}]},\"id\":\"cc6lo3zoip\"}}\n",
"headers": {
"Content-Type": [
"application/json"
Expand All @@ -27,22 +27,22 @@
"timeToLive": {
"unlimited": true
},
"id": "db35ffb7-82a0-fd33-96ec-fd786d3ebd61"
"id": "60221833-9eeb-958d-bff2-cb35633e7b1a"
},
{
"httpRequest": {
"body": {
"type": "JSON",
"json": "{\"data\":{\"attributes\":{\"resource_type\":\"kafka\",\"tags\":[\"myTag\",\"myTag2:myValue\"]},\"id\":\"testaddresourcetoconfluentaccountreturnsokresponse1665090164\",\"type\":\"confluent-cloud-resources\"}}"
"json": "{\"data\":{\"attributes\":{\"resource_type\":\"kafka\",\"tags\":[\"myTag\",\"myTag2:myValue\"]},\"id\":\"testaddresourcetoconfluentaccountreturnsokresponse1680789635\",\"type\":\"confluent-cloud-resources\"}}"
},
"headers": {},
"method": "POST",
"path": "/api/v2/integrations/confluent-cloud/accounts/l7mlzljfqc/resources",
"path": "/api/v2/integrations/confluent-cloud/accounts/cc6lo3zoip/resources",
"keepAlive": false,
"secure": true
},
"httpResponse": {
"body": "{\"data\":{\"attributes\":{\"resource_type\":\"kafka\",\"tags\":[\"myTag\",\"myTag2:myValue\"]},\"type\":\"confluent-cloud-resources\",\"id\":\"testaddresourcetoconfluentaccountreturnsokresponse1665090164\"}}\n",
"body": "{\"data\":{\"type\":\"confluent-cloud-resources\",\"attributes\":{\"tags\":[\"mytag\",\"mytag2:myvalue\"],\"resource_type\":\"kafka\"},\"id\":\"testaddresourcetoconfluentaccountreturnsokresponse1680789635\"}}\n",
"headers": {
"Content-Type": [
"application/json"
Expand All @@ -57,13 +57,13 @@
"timeToLive": {
"unlimited": true
},
"id": "55c22160-04b6-a484-6778-292f3ae8fed9"
"id": "a97b16fc-b20e-d59a-c298-ce43f624213c"
},
{
"httpRequest": {
"headers": {},
"method": "DELETE",
"path": "/api/v2/integrations/confluent-cloud/accounts/l7mlzljfqc",
"path": "/api/v2/integrations/confluent-cloud/accounts/cc6lo3zoip",
"keepAlive": false,
"secure": true
},
Expand All @@ -82,6 +82,6 @@
"timeToLive": {
"unlimited": true
},
"id": "2ef975aa-8d43-d06f-1acd-9c848145816b"
"id": "67351ab7-7775-fb3a-c03d-faf0ca6840a5"
}
]
2 changes: 1 addition & 1 deletion src/test/resources/com/datadog/api/client/v2/api/confluent_cloud.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Feature: Confluent Cloud
Then the response status is 201 OK
And the response "data.id" is equal to "{{ unique_lower_alnum }}"
And the response "data.attributes.resource_type" is equal to "kafka"
And the response "data.attributes.tags[0]" is equal to "myTag"
And the response "data.attributes.tags[0]" is equal to "mytag"

@generated @skip @team:Datadog/web-integrations
Scenario: Delete Confluent account returns "Bad Request" response
Expand Down