Conversation
jirikuncar
approved these changes
Nov 29, 2019
Contributor
jirikuncar
left a comment
jirikuncar
left a comment
There was a problem hiding this comment.
It looks nicer than the null params 👍
Contributor
|
/azp run |
|
Pull request contains merge conflicts. |
gzussa
approved these changes
Dec 4, 2019
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zippolyte
force-pushed
the
hippo/jov
branch
3 times, most recently
from
edd1d0e to
4c59256
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use builder pattern for requests, to make it backward compatible if new params are added.
Similar to OpenAPITools/openapi-generator#1341
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?