Skip to content

Remove templates from the build#78

Merged
nmuesch merged 1 commit intomasterfrom
nick/revert_template_addition
Feb 14, 2020
Merged

Remove templates from the build#78
nmuesch merged 1 commit intomasterfrom
nick/revert_template_addition

Conversation

@nmuesch
Copy link
Copy Markdown
Contributor

@nmuesch nmuesch commented Feb 13, 2020

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue, or add one feature, at the time.

What does this PR do?

This PR stops shipping the template files with the buildpack (and removes them from the gitignore)
Since this PR in the datadog-agent was merged DataDog/datadog-agent#4782, the template files are included in the agent binary directly and aren't needed here anymore.

I've tested a custom buildpack with the latest puppy agent off the master branch, and was able to successfully run the status command.

Review checklist (to be filled by reviewers)

  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@nmuesch nmuesch requested a review from a team as a code owner February 13, 2020 23:20
@nmuesch nmuesch merged commit bc919f4 into master Feb 14, 2020
@nmuesch nmuesch deleted the nick/revert_template_addition branch February 14, 2020 14:18
nmuesch added a commit that referenced this pull request Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants