Skip to content

refactor #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexgallotta wants to merge 2 commits into from
Closed

refactor #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19a514a
refactor
alexgallotta Oct 18, 2024
0f0564f
no need of propagator trait anymore
alexgallotta Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions bottlecap/src/config/trace_propagation_style.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
use std::{fmt::Display, str::FromStr};

use crate::traces::context::SpanContext;
use crate::traces::propagation::carrier::Extractor;
use crate::traces::propagation::text_map_propagator::extract_datadog;
use serde::{Deserialize, Deserializer};
use crate::traces::propagation::traceparent;

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum TracePropagationStyle {
Expand All @@ -11,6 +15,18 @@ pub enum TracePropagationStyle {
None,
}

impl TracePropagationStyle {
Copy link
Copy Markdown
Contributor

@duncanista duncanista Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy with coupling this into the propagation module which is going to be a crate eventually

pub fn extract(&self, carrier: &dyn Extractor) -> Option<SpanContext> {
match self {
TracePropagationStyle::Datadog => extract_datadog(carrier),
TracePropagationStyle::B3Multi => todo!(),
TracePropagationStyle::B3 => todo!(),
TracePropagationStyle::TraceContext => traceparent::extract(carrier),
TracePropagationStyle::None => todo!(),
}
}
}

impl FromStr for TracePropagationStyle {
type Err = String;

Expand Down
Loading