APIGW v1 + httpAPI/v1 API parameterized routes#419
Merged
astuyve merged 8 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Oct 21, 2024
Merged
APIGW v1 + httpAPI/v1 API parameterized routes#419astuyve merged 8 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom
astuyve merged 8 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom
Conversation
astuyve
changed the base branch from
main
to
jordan.gonzalez/bottlecap/universal-instrumentation
alexgallotta
approved these changes
Oct 21, 2024
duncanista
reviewed
Oct 21, 2024
Comment on lines
+8
to
+13
| use crate::lifecycle::invocation::triggers::{ | ||
| api_gateway_http_event::APIGatewayHttpEvent, Trigger, | ||
| }; | ||
|
|
||
| use super::triggers::api_gateway_rest_event::APIGatewayRestEvent; | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| use crate::lifecycle::invocation::triggers::{ | |
| api_gateway_http_event::APIGatewayHttpEvent, Trigger, | |
| }; | |
| use super::triggers::api_gateway_rest_event::APIGatewayRestEvent; | |
| use crate::lifecycle::invocation::triggers::{ | |
| api_gateway_http_event::APIGatewayHttpEvent, | |
| api_gateway_rest_event::APIGatewayRestEvent, | |
| Trigger, | |
| }; | |
duncanista
reviewed
Oct 21, 2024
Comment on lines
+67
to
+69
| debug!("MATCH V1 REST EVENT"); | ||
| if let Some(t) = APIGatewayRestEvent::new(payload_value) { | ||
| debug!("ASTUYVE PARSING V1 REST EVENT"); |
Contributor
There was a problem hiding this comment.
Should we remove this debug comments?
duncanista
reviewed
Oct 21, 2024
| } | ||
|
|
||
| s.trace_id = invocation_span.trace_id; | ||
| debug!("Final Span: {:?}", self.inferred_span); |
duncanista
approved these changes
Oct 21, 2024
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Left some comments, but overall LGTM
alexgallotta
pushed a commit
that referenced
this pull request
Nov 4, 2024
* feat: support APIGW v1 * feat: Tests for unparameterized payload working * feat: parameterized test * fix: specs * fix: unwrap_or_default, route has no http verb but is parameterized. * fix: lint * fix: Remove debugs, consolidate import * fix: oneline
duncanista
pushed a commit
that referenced
this pull request
Nov 15, 2024
* feat: support APIGW v1 * feat: Tests for unparameterized payload working * feat: parameterized test * fix: specs * fix: unwrap_or_default, route has no http verb but is parameterized. * fix: lint * fix: Remove debugs, consolidate import * fix: oneline
duncanista
pushed a commit
that referenced
this pull request
Nov 19, 2024
* feat: support APIGW v1 * feat: Tests for unparameterized payload working * feat: parameterized test * fix: specs * fix: unwrap_or_default, route has no http verb but is parameterized. * fix: lint * fix: Remove debugs, consolidate import * fix: oneline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datadog_wrapperdatadog_wrapper"datadog_wrapper(fix(universal-instrumentation): acceptdatadog_wrapper#373)