feat(bottlecap): add Distributed Tracing#423
Merged
duncanista merged 12 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Oct 23, 2024
Merged
Conversation
I suspect there might be something wrong here, the code in Go is quite convoluted
alexgallotta
approved these changes
Oct 23, 2024
alexgallotta
approved these changes
Oct 23, 2024
also updated some variable names
duncanista
merged commit 891d7b2
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
deleted the
jordan.gonzalez/bottlecap/use-composite-propagator
branch
alexgallotta
pushed a commit
that referenced
this pull request
Nov 4, 2024
* headers `HeaderMap` to `HashMap` * add `Send` to propagators traits * add `serde_json::Value` extractor + injector * add `get_carrier` to `Trigger` trait * add `get_carrier` method to current inferred spans * update `span_inferrer.rs` to use `get_carrier` methods for distributed tracing * add `headers_to_map` function * reparent spans I suspect there might be something wrong here, the code in Go is quite convoluted * make some variables public * fix to return early on `extract_span_context` * fix how 128 bit is handled also updated some variable names * update comment
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* headers `HeaderMap` to `HashMap` * add `Send` to propagators traits * add `serde_json::Value` extractor + injector * add `get_carrier` to `Trigger` trait * add `get_carrier` method to current inferred spans * update `span_inferrer.rs` to use `get_carrier` methods for distributed tracing * add `headers_to_map` function * reparent spans I suspect there might be something wrong here, the code in Go is quite convoluted * make some variables public * fix to return early on `extract_span_context` * fix how 128 bit is handled also updated some variable names * update comment
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* headers `HeaderMap` to `HashMap` * add `Send` to propagators traits * add `serde_json::Value` extractor + injector * add `get_carrier` to `Trigger` trait * add `get_carrier` method to current inferred spans * update `span_inferrer.rs` to use `get_carrier` methods for distributed tracing * add `headers_to_map` function * reparent spans I suspect there might be something wrong here, the code in Go is quite convoluted * make some variables public * fix to return early on `extract_span_context` * fix how 128 bit is handled also updated some variable names * update comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds correct integration for Distributed Tracing
How?
By using the
DatadogCompositePropagator, we can extract span context to be used for the current invocation.Testing
Notes