[SVLS-5714] Add lambda network enhanced metrics#424
Merged
shreyamalpani merged 3 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Oct 23, 2024
Conversation
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
| ); | ||
| lambda_enhanced_metrics.increment_invocation_metric(); | ||
| let mut p = invocation_processor.lock().await; | ||
| p.on_invoke_event(request_id); |
Contributor
There was a problem hiding this comment.
Wonder since this is always invoked first, if we might need to change the constructor for the context buffer, simplifying our logic. As I'm not sure if this would guarantee us to always have this operation to exist before any other hook from the telemetry API, we might need some experiment to check!
Contributor
Author
There was a problem hiding this comment.
Had a discussion about this with Jordan, will do in a future PR!
Contributor
|
Amazing work, this is taking a much much better form! 🎉 |
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
reviewed
Oct 23, 2024
duncanista
approved these changes
Oct 23, 2024
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Left some non-blocking comments! Amazing work
shreyamalpani
merged commit ada1414
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
pushed a commit
that referenced
this pull request
Nov 15, 2024
* send network enhanced metrics * naming fixes * reformatting reading data from proc
duncanista
pushed a commit
that referenced
this pull request
Nov 19, 2024
* send network enhanced metrics * naming fixes * reformatting reading data from proc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces three new enhanced lambda metrics. Each of the metrics are emitted once per invocation and represent network usage by the lambda function.
The three new metrics are:
aws.lambda.enhanced.rx_bytes- bytes received by the functionaws.lambda.enhanced.tx_bytes- bytes transmitted by the functionaws.lambda.enhanced.total_network- sum ofaws.lambda.enhanced.rx_bytesandaws.lambda.enhanced.tx_bytesDescribe how to test/QA changes
Additional Notes