fix(bottlecap): add trigger tags to invocation span#428
Merged
duncanista merged 3 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Oct 30, 2024
Conversation
duncanista
changed the base branch from
main
to
jordan.gonzalez/bottlecap/universal-instrumentation
alexgallotta
approved these changes
Oct 29, 2024
duncanista
merged commit bc607ef
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
deleted the
jordan.gonzalez/bottlecap/invocation-span-uses-trigger-tags
branch
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* use `get_tags` from `Trigger` trait * remove unneeded comment * add trigger tags to invocation span
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* use `get_tags` from `Trigger` trait * remove unneeded comment * add trigger tags to invocation span
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Trigger tags now will be showed on the invocation span.
How
Uses the
get_tagsmethod in theSpanInferrerwhen an inferred span is present, allowing us to later use to add them to the invocation span.Notes
Minor refactored removing unnecessary method for a reference of our inferred span.