feat(bottlecap): add SQS inferred span#434
Merged
duncanista merged 27 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 7, 2024
Merged
feat(bottlecap): add SQS inferred span#434duncanista merged 27 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom
duncanista merged 27 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom
Conversation
…extension into aj/sns-sqs
…extension into aj/sns-sqs
…extension into aj/sns-sqs
duncanista
changed the base branch from
main
to
jordan.gonzalez/bottlecap/universal-instrumentation
or else theres nothing to extract, reset values also for next inferr, no need to keep state after we complete
alexgallotta
approved these changes
Nov 6, 2024
duncanista
merged commit 63e4ae3
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* wip: sqs * feat: sqs tests * invert duration check * remove duration set * fmt and add `test_get_arn` * remove unneeded reference * remove unneeded comments * add `get_carrier` implementation for `SqsRecord` * add trace context to `sqs_event.json` * fix: resource_names is not needed * fix: don't deserialize body * avoid `use super::...` * fix unit tests * set carrier and trigger tags * remove duplicate tag * fmt * pass headers to `on_invocation_end` * infer first, then extract or else theres nothing to extract, reset values also for next inferr, no need to keep state after we complete * reset values on every infer * move some constants * add missing trigger tags * missed one case --------- Co-authored-by: AJ Stuyvenberg <astuyve@gmail.com>
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* wip: sqs * feat: sqs tests * invert duration check * remove duration set * fmt and add `test_get_arn` * remove unneeded reference * remove unneeded comments * add `get_carrier` implementation for `SqsRecord` * add trace context to `sqs_event.json` * fix: resource_names is not needed * fix: don't deserialize body * avoid `use super::...` * fix unit tests * set carrier and trigger tags * remove duplicate tag * fmt * pass headers to `on_invocation_end` * infer first, then extract or else theres nothing to extract, reset values also for next inferr, no need to keep state after we complete * reset values on every infer * move some constants * add missing trigger tags * missed one case --------- Co-authored-by: AJ Stuyvenberg <astuyve@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds SQS inferred spans
How?
Allowing SQS events
Notes
Not doing SNS-SQS yet