fix(bottlecap): filter http, tcp and local spans#439
Merged
alexgallotta merged 8 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 8, 2024
Merged
Conversation
duncanista
reviewed
Nov 7, 2024
duncanista
reviewed
Nov 7, 2024
duncanista
reviewed
Nov 7, 2024
duncanista
reviewed
Nov 7, 2024
duncanista
reviewed
Nov 8, 2024
duncanista
reviewed
Nov 8, 2024
duncanista
reviewed
Nov 8, 2024
duncanista
reviewed
Nov 8, 2024
duncanista
approved these changes
Nov 8, 2024
duncanista
changed the title
alexgallotta
merged commit 9583b54
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* filter http, tcp and local spans * fix original condition * update comments * reuse constants and match sytle * Update bottlecap/src/traces/mod.rs * Update bottlecap/src/traces/mod.rs * Update bottlecap/src/traces/mod.rs * Update bottlecap/src/traces/mod.rs --------- Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* filter http, tcp and local spans * fix original condition * update comments * reuse constants and match sytle * Update bottlecap/src/traces/mod.rs * Update bottlecap/src/traces/mod.rs * Update bottlecap/src/traces/mod.rs * Update bottlecap/src/traces/mod.rs --------- Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Filters spans through a more strict set of rules
Why?
We need to filter out spans generated by us, or created by other internal systems