feat(bottlecap): generate tmp enhanced metrics#443
Merged
shreyamalpani merged 8 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 12, 2024
Merged
Conversation
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
shreyamalpani
changed the title
…sal-instrumentation' into shreya.malpani/tmp-enhanced-metrics
duncanista
reviewed
Nov 12, 2024
duncanista
reviewed
Nov 12, 2024
duncanista
reviewed
Nov 12, 2024
duncanista
approved these changes
Nov 12, 2024
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Left some comments, but approving in the meantime!
Looks good!
shreyamalpani
merged commit 1d56bb0
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
pushed a commit
that referenced
this pull request
Nov 15, 2024
* generate tmp enhanced metrics * fix channel stop signal * use tokio async task instead of thread * statfs fix * fixes * remove unused import * rename tmp_chan to tmp_chan_tx
duncanista
pushed a commit
that referenced
this pull request
Nov 19, 2024
* generate tmp enhanced metrics * fix channel stop signal * use tokio async task instead of thread * statfs fix * fixes * remove unused import * rename tmp_chan to tmp_chan_tx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces three new enhanced lambda metrics. These metrics are emitted once per invocation and represent space used and space available in the
/tmpdirectory.The three new metrics are:
aws.lambda.enhanced.tmp_max- max available bytes in/tmpaws.lambda.enhanced.tmp_used- bytes used or reserved in/tmpaws.lambda.enhanced.tmp_free- bytes available in/tmpDescribe how to test/QA changes
Additional Notes
tmp_usedreflects a peak over the course of the request. Suppose 2000 bytes are written to/tmp, then deleted, then 3000 bytes are written, then deleted. The metric will report 3000.