feat(bottlecap): add Kinesis inferred spans#445
Merged
alexgallotta merged 7 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 12, 2024
Merged
Conversation
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
duncanista
reviewed
Nov 11, 2024
alexgallotta
force-pushed
the
alexgallotta/kinesis
branch
2 times, most recently
from
bce28bf to
809bc90
Compare
Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
alexgallotta
force-pushed
the
alexgallotta/kinesis
branch
from
809bc90 to
17cc8cf
Compare
duncanista
reviewed
Nov 12, 2024
duncanista
reviewed
Nov 12, 2024
duncanista
approved these changes
Nov 12, 2024
Contributor
duncanista
left a comment
duncanista
left a comment
There was a problem hiding this comment.
Looks good!
Left a minor comment!
alexgallotta
merged commit 2cb4d17
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* add kinesis * Update bottlecap/src/lifecycle/invocation/triggers/kinesis_event.rs Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com> * group up import and address comments * fix timestamp, it's in seconds * fix clippy * deserialized carrier * remove manual deref and resourcename meta tag since it is not used --------- Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* add kinesis * Update bottlecap/src/lifecycle/invocation/triggers/kinesis_event.rs Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com> * group up import and address comments * fix timestamp, it's in seconds * fix clippy * deserialized carrier * remove manual deref and resourcename meta tag since it is not used --------- Co-authored-by: jordan gonzález <30836115+duncanista@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.