feat(bottlecap): add Lambda Function URL inferred spans#451
Merged
duncanista merged 3 commits intojordan.gonzalez/bottlecap/universal-instrumentationfrom Nov 13, 2024
Conversation
alexgallotta
approved these changes
Nov 13, 2024
duncanista
commented
Nov 13, 2024
| } | ||
|
|
||
| fn get_arn(&self, region: &str) -> String { | ||
| let function_name = env::var("AWS_LAMBDA_FUNCTION_NAME").unwrap_or_default(); |
Contributor
Author
There was a problem hiding this comment.
Don't like doing this, but I'd rather do this than pass another field and modify the whole struct trigger architecture
duncanista
merged commit f639aae
into
jordan.gonzalez/bottlecap/universal-instrumentation
duncanista
added a commit
that referenced
this pull request
Nov 15, 2024
* add `LambdaFunctionUrlEvent` * fmt * update span inferrer
duncanista
added a commit
that referenced
this pull request
Nov 19, 2024
* add `LambdaFunctionUrlEvent` * fmt * update span inferrer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds Lambda Function Url inferred spans
How?
Adding the
LambdaFunctionUrlEventtrigger implementation