[breaking] FIPS compliant metrics + secrets management#649
Merged
Conversation
nhulston
changed the title
nhulston
changed the title
| await expect(listener.onCompleteInvocation()).resolves.toEqual(undefined); | ||
| }); | ||
|
|
||
| it("configures FIPS endpoint for GovCloud regions", async () => { |
Contributor
There was a problem hiding this comment.
should we keep a version of this test like configures FIPS endpoint for FIPS_MODE_ENABLED?
Contributor
Author
There was a problem hiding this comment.
I moved those tests to fips.spec.ts; since we're moving the FIPS enabled/disabled logic to there, this was a little redundant
apiarian-datadog
approved these changes
May 9, 2025
Contributor
apiarian-datadog
left a comment
apiarian-datadog
left a comment
There was a problem hiding this comment.
looking good. added a note about a deleted test but fine otherwise. we'll add statsd timestamp support separately?
Contributor
Author
Thanks! Yes, I added timestamp support in #648 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_LAMBDA_FIPS_MODEenv var. By default, govcloud regions are FIPS enabled, and commercial regions are FIPS disabled. However, this default can be overridden by settingDD_LAMBDA_FIPS_MODEtotrueor `falseMotivation
FIPS compliance
https://datadoghq.atlassian.net/browse/SVLS-6295
Testing Guidelines
Manually - the fips enabled follows expected behavior based on region + env var
Unit tests
Additional Notes
Breaking because customers with FIPS enabled and no extension/forwarder will no longer be able to send metrics.
Types of Changes
Check all that apply