Open
Conversation
|
|
||
| from ddtrace import patch | ||
| from ddtrace import __version__ as ddtrace_version | ||
| from ddtrace.internal.telemetry import telemetry_writer |
Contributor
There was a problem hiding this comment.
I recall that importing the telemetry writer added a bunch of cold start time. Did you happen to check to see what impact it's had this time around?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the configuration that disables instrumentation telemetry and replaces it with a single telemetry upload during cold start, per the Instrumentation Telemetry For Serverless RFC.
DataDog/dd-trace-py#17661 makes this change work as described in the Instrumentation Telemetry For Serverless RFC.