[CONTP-1397] add admission controller probe configuration#2720
Conversation
6befdb4 to
9fd1dd7
Compare
07c1cbe to
3c9f966
Compare
3c9f966 to
d99e0f6
Compare
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| controller-gen.kubebuilder.io/version: v0.17.3 |
There was a problem hiding this comment.
not sure why this changed
| - deletecollection | ||
| - list | ||
| - watch |
There was a problem hiding this comment.
Not sure why these keep being added when running make build. They seem redundant, we already have '*' just above.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2720 +/- ##
==========================================
+ Coverage 38.80% 38.81% +0.01%
==========================================
Files 309 309
Lines 26750 26803 +53
==========================================
+ Hits 10379 10404 +25
- Misses 15592 15620 +28
Partials 779 779
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53dfcbc913
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if f.probeConfig != nil && f.probeConfig.enabled { | ||
| managers.EnvVar().AddEnvVarToContainer(apicommon.ClusterAgentContainerName, &corev1.EnvVar{ | ||
| Name: DDAdmissionControllerProbeEnabled, | ||
| Value: "true", | ||
| }) |
There was a problem hiding this comment.
Propagate explicit probe disable to Cluster Agent
When features.admissionController.probe.enabled is set to false, this block skips writing DD_ADMISSION_CONTROLLER_PROBE_ENABLED entirely, so the user’s explicit disable is never propagated to the Cluster Agent. In clusters where the agent-side default is enabled (the API/docs describe probe default as true), the probe will remain active despite enabled: false; emit the enabled env var with the configured boolean value and only gate interval/grace-period env vars.
Useful? React with 👍 / 👎.
tbavelier
left a comment
There was a problem hiding this comment.
discussed offline, not worth the added complexity for something minor/harmless. LGTM
What does this PR do?
Adds configuration for
admission_controller.probeMinimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Deploy the operator and apply the following:
After the cluster agent is Running, check the output of
agent statuson the leader cluster agent replica, it should contain a section for the admission controller network probe with successful executions:Or just check the output of
agent config -aon the cluster agent and ensure thatadmission_controller.probe.enabledistrueChecklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel