Closed
Conversation
* Add cluster_name as tag * Add updater_type
🛑 Gate Violations
ℹ️ Info🎯 Code Coverage (details) Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: f3aad2b | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## khewonc/experiment-signals #2913 +/- ##
==============================================================
- Coverage 40.54% 40.50% -0.04%
==============================================================
Files 321 320 -1
Lines 28514 28395 -119
==============================================================
- Hits 11560 11501 -59
+ Misses 16107 16048 -59
+ Partials 847 846 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Read the target
DatadogAgentnamespace/name from theUPDATER_TASKparams directly (via a newparseTaskNSNhelper) for start, stop, and promote operations, instead of storing it in aexperimentTargetfield on the daemon struct.Motivation
Previously, stop and promote operations relied on
d.experimentTargetbeing set by a prior start call. This stateful approach was fragile — if the daemon restarted between start and stop/promote, the target was lost. Carrying the name in every task payload makes each operation self-contained and idempotent.Additional Notes
experimentTarget types.NamespacedNamefield from the daemon struct.NamespacedNameis now a field ofexperimentParams(carried in the task itself).validateOperationtests for empty name/namespace are replaced byparseTaskNSNtests.Minimum Agent Versions
No minimum version requirements.
Describe your test plan
Unit tests in
pkg/fleet/daemon_test.goandpkg/fleet/remote_config_test.goare updated to passNamespacedNameinsideexperimentParams. NewTestParseTaskNSN_*tests cover the valid, missing-name, and missing-namespace cases.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel