This repository was archived by the owner on Jul 27, 2023. It is now read-only.
kubernetes: Collect local pod and container state from kubelet#10
Merged
conorbranagan merged 1 commit intomasterfrom Jul 10, 2017
Merged
kubernetes: Collect local pod and container state from kubelet#10conorbranagan merged 1 commit intomasterfrom
conorbranagan merged 1 commit intomasterfrom
Conversation
In an earlier change we cached the Kubernetes metadata state to avoid additional load on a server. But this had the trade-off that we would have out-of-date information which is definitely not great for high-churn containers. So as a solution this change will make is so we _always_ query the local kubelet (which should be a very light, local query) for pod and container state. This local data is merged with the global data to provide both an up-to-date view as well as data that only comes from the master (deployments, services). The final trade-off is that we could have pods/containers that aren't initially attached to their deployment or service until the next global fetch.
conorbranagan
force-pushed
the
conor/k8s-kubelet
branch
from
a072bdd to
98d772d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an earlier change we cached the Kubernetes metadata state to avoid
additional load on a server. But this had the trade-off that we would
have out-of-date information which is definitely not great for
high-churn containers.
So as a solution this change will make is so we always query the local
kubelet (which should be a very light, local query) for pod and
container state. This local data is merged with the global data to
provide both an up-to-date view as well as data that only comes from the
master (deployments, services).
The final trade-off is that we could have pods/containers that aren't
initially attached to their deployment or service until the next global
fetch.
(Note some of this code was lifted from DataDog/datadog-agent#285
and will certainly need consolidation later on as, potentially, a more
robust kubernetes metadata provider)