Move rejected AWS terms to substitution list #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR, I've deleted the list of rejected AWS brand names from the existing vocabulary, and replaced it with a list of substitutions instead. That way, when someone writes something like
AWS ECR, they get an immediate suggestion to replace it withAmazon ECR, so they don't have to spend time looking up what the preferred term is.If you're reviewing this, please let me know if you see anything about this approach that can be improved!
Motivation
The approach I've chosen seems to provide the most functionality:
AWS WorkspacesandAWS WorkSpacesneed to be corrected toAmazon WorkSpaces.accept.txtfile allows us to retain detections in case someone uses the right term but with incorrect capitalization (for example,Amazon Cloudfrontwill get properly corrected toAmazon CloudFront).Release
Additional Notes
Release checklist