[branch-50] Revert arrow upgrade and related changes #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Again, the test is failing with |
LiaCastaneda
commented
Sep 30, 2025
| ---- | ||
| logical_plan TableScan: t projection=[int_col, str_col] | ||
| physical_plan DataSourceExec: file_groups={2 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/listing_table_statistics/1.parquet], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/listing_table_statistics/2.parquet]]}, projection=[int_col, str_col], file_type=parquet, statistics=[Rows=Exact(4), Bytes=Exact(212), [(Col[0]: Min=Exact(Int64(-1)) Max=Exact(Int64(3)) Null=Exact(0)),(Col[1]: Min=Exact(Utf8View("a")) Max=Exact(Utf8View("d")) Null=Exact(0))]] | ||
| physical_plan DataSourceExec: file_groups={2 groups: [[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/listing_table_statistics/1.parquet], [WORKSPACE_ROOT/datafusion/sqllogictest/test_files/scratch/listing_table_statistics/2.parquet]]}, projection=[int_col, str_col], file_type=parquet, statistics=[Rows=Exact(4), Bytes=Exact(288), [(Col[0]: Min=Exact(Int64(-1)) Max=Exact(Int64(3)) Null=Exact(0)),(Col[1]: Min=Exact(Utf8View("a")) Max=Exact(Utf8View("d")) Null=Exact(0))]] |
Author
There was a problem hiding this comment.
This was Bytes=Exact(288) before the arrow upgrade
gabotechs
approved these changes
Sep 30, 2025
gabotechs
left a comment
gabotechs
left a comment
There was a problem hiding this comment.
👍 It looks like we are losing pretty much nothing with this revert, let's go!
Comment on lines
-2205
to
-2214
| DataType::Decimal32(_precision, _scale) => { | ||
| return _not_impl_err!( | ||
| "Decimal32 not supported in ScalarValue::iter_to_array" | ||
| ); | ||
| } | ||
| DataType::Decimal64(_precision, _scale) => { | ||
| return _not_impl_err!( | ||
| "Decimal64 not supported in ScalarValue::iter_to_array" | ||
| ); | ||
| } |
LiaCastaneda
added a commit
that referenced
this pull request
Oct 2, 2025
This reverts commit 5506e69.
gabotechs
changed the title
LiaCastaneda
added a commit
that referenced
this pull request
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Reverts the arrow V56 upgrade back to version 55.x , along with PRs that depend on arrow features from V56.