Merged
Conversation
zippolyte
force-pushed
the
hippo/flare_sanitize_token
branch
from
3c570c4 to
57cb2bf
Compare
olivielpeau
approved these changes
Jul 10, 2017
This was referenced Jul 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
re.search()instead ofre.match().re.match()only matches at the beginning of the line.That would prevent the replacement of password or token if it was the first option of an instance (i.e. there would be a dash
-before the parameter). Noticed this while writing the tests.Motivation
Added functionality to auth via token in the consul check: DataDog/integrations-core#521
Need to sanitize config file
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?