Skip to content

Ensure RNG seeded at fork#45

Merged
willgittoes-dd merged 2 commits into
masterfrom
willgittoes-dd/fork-safe-random-numbers
Sep 6, 2018
Merged

Ensure RNG seeded at fork#45
willgittoes-dd merged 2 commits into
masterfrom
willgittoes-dd/fork-safe-random-numbers

Conversation

@willgittoes-dd
Copy link
Copy Markdown
Contributor

@willgittoes-dd willgittoes-dd commented Sep 6, 2018

rnburns kindly pointed out an issue with random number generation

btw it looks like your method of generating ids is going to run into this issue #52

This is how I fixed it for the other tracers: lightstep/lightstep-tracer-cpp#110

@willgittoes-dd willgittoes-dd added the bug Something isn't working label Sep 6, 2018
Copy link
Copy Markdown
Contributor

@cgilmour cgilmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. If it can be done without direct pthread calls in the future that might be cleaner

@willgittoes-dd willgittoes-dd merged commit 55b70dd into master Sep 6, 2018
@willgittoes-dd willgittoes-dd deleted the willgittoes-dd/fork-safe-random-numbers branch September 6, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants