Add a CI job that builds dd-opentracing-cpp using bazel#60
Merged
Conversation
Contributor
Something I've been meaning to do for ages! I've made a task for it. |
willgittoes-dd
approved these changes
Oct 16, 2018
Contributor
Author
|
This is going to conflict with #59, so I'll rebase and fixup this one after that is merged. |
cgilmour
force-pushed
the
cgilmour/add-bazel-ci
branch
from
eee32c6 to
a3184e7
Compare
cgilmour
force-pushed
the
cgilmour/add-bazel-ci
branch
from
d8d8fa0 to
429f778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following from the datadog-library PR that adds bazel to the "build" image, this PR uses that image and runs
bazel buildon the project.Part of this change is adding a strict set of compiler error and warning flags to match downstream projects (eg: envoy), and this PR includes fixes for the errors that were emitted.
Since the cmake build compiles a different set of files, those flags could also be added to the cmake config as a separate change.