[RUM-12493] [V3] RUM Session ID based Consistent Trace Sampling #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
changed the title
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12493/rum-session-id-based-trace-sampling
branch
2 times, most recently
from
390ba0d to
fcfaf0e
Compare
sbarrio
previously approved these changes
Dec 10, 2025
Contributor
sbarrio
left a comment
sbarrio
left a comment
There was a problem hiding this comment.
Very thorough tests, top notch work!
sbarrio
force-pushed
the
sbarrio/RUM-12894/initialization-api-restructuring-for-modularization
branch
from
41ea1eb to
edd7045
Compare
Base automatically changed from
sbarrio/RUM-12894/initialization-api-restructuring-for-modularization
to
feature/v3
December 10, 2025 10:43
sbarrio
dismissed stale reviews from fuzzybinary and themself
The base branch was changed.
sbarrio
previously approved these changes
Dec 11, 2025
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12493/rum-session-id-based-trace-sampling
branch
from
fcfaf0e to
3e0c785
Compare
…n-api-restructuring-for-modularization [RUM-12894] [V3] New Configuration object and initialization API to support Modularization
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12493/rum-session-id-based-trace-sampling
branch
from
3e0c785 to
bfdb696
Compare
sbarrio
approved these changes
Dec 15, 2025
marco-saia-datadog
deleted the
marcosaia/RUM-12493/rum-session-id-based-trace-sampling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the logic to determine whether the trace should be sampled or not, by using the RUM Session ID first, before using the Trace sampling if no session can be found.
Motivation
Consistent trace sampling based on RUM Session ID allows RUM clients and the backend to come to a the same decision about sampling without relying on randomness for each trace.
Additional Notes
Review checklist (to be filled by reviewers)