[CHORE/FIX] [V3] Refactor modules to use Singleton Global Instance #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-saia-datadog
force-pushed
the
marcosaia/chore/use-singleton-helper
branch
from
3f8827b to
8210b19
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-12493/rum-session-id-based-trace-sampling
branch
2 times, most recently
from
3e0c785 to
bfdb696
Compare
Base automatically changed from
marcosaia/RUM-12493/rum-session-id-based-trace-sampling
to
feature/v3
December 15, 2025 10:59
marco-saia-datadog
dismissed
sbarrio’s stale review
The base branch was changed.
* Fixes an issue that happens consistently on Expo, where the import duplicates the isInitialized state variable, preventing the SDK to be correctly attached to the native implementation
marco-saia-datadog
force-pushed
the
marcosaia/chore/use-singleton-helper
branch
2 times, most recently
from
13370e3 to
705b2e9
Compare
sbarrio
previously approved these changes
Dec 15, 2025
* Solves an issue where the config object is duplicated for multiple imports leading to incorrect state management, and interaction tracking being disabled
marco-saia-datadog
force-pushed
the
marcosaia/chore/use-singleton-helper
branch
from
705b2e9 to
06b6ddc
Compare
sbarrio
reviewed
Dec 15, 2025
| }); | ||
|
|
||
| it('does nothing when startTrackingViews { undefined any ', async () => { | ||
| it('does nothing when startTrackingViews { undefined any }', async () => { |
sbarrio
reviewed
Dec 15, 2025
| }; | ||
| } | ||
|
|
||
| export const DdRumReactNavigationTracking = getGlobalInstance( |
Contributor
There was a problem hiding this comment.
Seeing this, I think we should do the same for DdRumReactNativeNavigationTracking.tsx (on this or on a separate PR).
sbarrio
reviewed
Dec 15, 2025
| this.paramsTrackingPredicate = defaultParamsPredicate; | ||
| this.viewNamePredicate = defaultViewNamePredicate; | ||
| this.viewTrackingPredicate = defaultViewTrackingPredicate; | ||
| } |
sbarrio
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors relevant modules to use the
getGlobalInstance()singleton pattern.Motivation
Prevents problems caused by static properties having different values when imported from multiple sources.
Review checklist (to be filled by reviewers)