Enable core testing to be called before native init on iOS #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louiszawadzki
commented
Mar 26, 2024
| self.coreProxy?.waitAndDeleteEvents(ofFeature: "logging") | ||
| self.coreProxy?.waitAndDeleteEvents(ofFeature: "tracing") | ||
| self.coreProxy?.waitAndDeleteEvents(ofFeature: "session-replay") | ||
| let coreProxy = (DatadogSDKWrapper.shared.getCoreInstance() as! DatadogCoreProxy) |
Contributor
Author
There was a problem hiding this comment.
I saw another potential solution to create a singleton to hold the proxied core instance, but I felt there was no point in adding another singleton to the one we already had that will return the proxied core given enable was called before.
maxep
approved these changes
Mar 27, 2024
louiszawadzki
deleted the
louiszawadzki/rum-750/enable-core-testing-on-ios-for-native-init
branch
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For Core Testing to work on iOS it needs to be enabled before the SDK is initialized.
With the introduction of the native initialization, we could not perform this step with the current version of the Core Testing.
This PR adds a static method that can be called before the DD SDK is initialized so we can still collect events.
Review checklist (to be filled by reviewers)