[RUM-9615] Copy Debug ID in Hermes composed sourcemaps before upload #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 663 Passed, 1 Skipped, 5.27s Total Time |
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9615/copy-debug-id-in-composed-sourcemap
branch
from
5903f09 to
a816075
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
sbarrio
reviewed
May 9, 2025
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9615/copy-debug-id-in-composed-sourcemap
branch
from
a816075 to
2db6428
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9615/copy-debug-id-in-composed-sourcemap
branch
from
2db6428 to
7d35690
Compare
sbarrio
approved these changes
Jun 18, 2025
marco-saia-datadog
removed
the
Do not merge
cdn34dd
approved these changes
Jun 19, 2025
marco-saia-datadog
deleted the
marcosaia/RUM-9615/copy-debug-id-in-composed-sourcemap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
datadog-sourcemaps.gradlescript to add an additional step that ensures the Debug ID is preserved during source map composition.The Debug ID is automatically copied from the packager generated source map to the Hermes composed source map, as the property is lost during the composition process.
To support this, a new JavaScript utility script has been introduced at
./packages/core/scripts/copy-debug-id.js, which performs the actual copy of the JSON property from one file to the other.Review checklist (to be filled by reviewers)