-
Notifications
You must be signed in to change notification settings - Fork 53
Bump Android SDK to 2.21.0 and fix android build errors on RN <0.76 #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Android SDK to 2.21.0 and fix android build errors on RN <0.76 #896
Conversation
d8296fa to
3dfe088
Compare
Datadog ReportBranch report: ✅ 0 Failed, 663 Passed, 1 Skipped, 3.74s Total Time |
1ffc54e to
67ae2b0
Compare
67ae2b0 to
2976783
Compare
|
@0xnm Pinging you here to double check if this approach seems reasonable enough or if you think we should explore an alternative to get Android builds on RN 0.76 to work with newer versions of dd-sdk-android 🙇 |
marco-saia-datadog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
2976783 to
67c2a8c
Compare
What does this PR do?
androidx.metrics:metrics-performance:1.0.0-beta02:The solution for this has been to force the resolution to androidx.metrics:metrics-performance:1.0.0-beta01 when building for React Native versions under 0.76.0.
This dependency was original bumped here: DataDog/dd-sdk-android#2546
Review checklist (to be filled by reviewers)