Skip to content

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented May 30, 2025

What does this PR do?

  • Bumps the native Android SDK dependency to 2.21.0.
  • Fixes a build issue related to the inclusion of androidx.metrics:metrics-performance:1.0.0-beta02:
 1.  Dependency 'androidx.metrics:metrics-performance:1.0.0-beta02' requires Android Gradle plugin 8.6.0 or higher.
 
       This build currently uses Android Gradle plugin 8.5.0.

The solution for this has been to force the resolution to androidx.metrics:metrics-performance:1.0.0-beta01 when building for React Native versions under 0.76.0.

This dependency was original bumped here: DataDog/dd-sdk-android#2546

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0-fix-pre-rn-76-build-error branch from d8296fa to 3dfe088 Compare May 30, 2025 12:19
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 30, 2025

Datadog Report

Branch report: sbarrio/dev/bump-android-sdk-to-2.21.0-fix-pre-rn-76-build-error
Commit report: 67c2a8c
Test service: dd-sdk-reactnative

✅ 0 Failed, 663 Passed, 1 Skipped, 3.74s Total Time

@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0-fix-pre-rn-76-build-error branch 3 times, most recently from 1ffc54e to 67ae2b0 Compare May 30, 2025 15:30
@sbarrio sbarrio self-assigned this Jun 2, 2025
@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0-fix-pre-rn-76-build-error branch from 67ae2b0 to 2976783 Compare June 2, 2025 12:45
@sbarrio sbarrio marked this pull request as ready for review June 2, 2025 13:27
@sbarrio sbarrio requested a review from a team as a code owner June 2, 2025 13:27
@sbarrio sbarrio requested a review from 0xnm June 9, 2025 08:43
@sbarrio
Copy link
Contributor Author

sbarrio commented Jun 9, 2025

@0xnm Pinging you here to double check if this approach seems reasonable enough or if you think we should explore an alternative to get Android builds on RN 0.76 to work with newer versions of dd-sdk-android 🙇

Copy link
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0-fix-pre-rn-76-build-error branch from 2976783 to 67c2a8c Compare June 16, 2025 09:04
@sbarrio sbarrio merged commit 42eb1a9 into develop Jun 18, 2025
10 checks passed
@sbarrio sbarrio deleted the sbarrio/dev/bump-android-sdk-to-2.21.0-fix-pre-rn-76-build-error branch June 18, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants