Skip to content

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Jun 5, 2025

What does this PR do?

Dependabot has notified us of a security issue that could cause Denial of Service attacks related to rexml on both of our example apps. Bumping it to 3.3.6 solves the problem.

From https://github.com/DataDog/dd-sdk-reactnative/security/dependabot/10

The REXML gem before 3.3.6 has a DoS vulnerability when it parses an XML that has many deep elements that have same local name attributes.

If you need to parse untrusted XMLs with tree parser API like REXML::Document.new, you may be impacted to this vulnerability. If you use other parser APIs such as stream parser API and SAX2 parser API, this vulnerability is not affected.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio marked this pull request as ready for review June 5, 2025 16:33
@sbarrio sbarrio requested a review from a team as a code owner June 5, 2025 16:33
@sbarrio sbarrio changed the title Bump rexml to 3.3.6 on example apps to avoid security issues Bump rexml to 3.3.6 on example apps to avoid potential DoS issues Jun 5, 2025
@sbarrio sbarrio changed the title Bump rexml to 3.3.6 on example apps to avoid potential DoS issues Bump rexml to 3.3.6 on example apps to avoid potential DoS vulnerability Jun 5, 2025
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: sbarrio/fix/security-dependency-rexml
Commit report: 53d219a
Test service: dd-sdk-reactnative

✅ 0 Failed, 663 Passed, 1 Skipped, 3.75s Total Time

@sbarrio sbarrio self-assigned this Jun 6, 2025
@sbarrio sbarrio merged commit 9806e6a into develop Jun 17, 2025
10 checks passed
@sbarrio sbarrio deleted the sbarrio/fix/security-dependency-rexml branch June 17, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants