Skip to content

[Fix] Make androidx.metrics:metrics-performance:1.0.0-beta01 resolution more robust (RN <0.76) #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbarrio wants to merge 1 commit into from
Closed

[Fix] Make androidx.metrics:metrics-performance:1.0.0-beta01 resolution more robust (RN <0.76) #937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/core/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ dependencies {
// From 2.21.0, it uses 1.0.0-beta02, which requires Gradle 8.6.0.
// This breaks builds if the React Native target is below 0.76.0. as it relies on Gradle 8.5.0.
// To avoid this, we enforce 1.0.0-beta01 on RN < 0.76.0
if (reactNativeMinorVersion < 76) {
if (reactNativeMajorVersion == 0 && reactNativeMinorVersion < 76) {
implementation("com.datadoghq:dd-sdk-android-rum:2.25.0") {
exclude group: "androidx.metrics", module: "metrics-performance"
}
Expand Down Expand Up @@ -286,4 +286,17 @@ project.afterEvaluate {
project.android.unitTestVariants.all { variant ->
variant.registerPreJavacGeneratedBytecode(outputJarDependency)
}

// dd-sdk-android-rum requires androidx.metrics:metrics-performance.
// From 2.21.0, it uses 1.0.0-beta02, which requires Gradle 8.6.0.
// This breaks builds if the React Native target is below 0.76.0. as it relies on Gradle 8.5.0.
// To avoid this, we enforce 1.0.0-beta01 on RN < 0.76.0
// This resolution ensures that version 1.0.0-beta01 will be used even if another dependency also includes androidx.metrics:metrics-performance
if (reactNativeMajorVersion == 0 && reactNativeMinorVersion < 76) {
configurations.all {
resolutionStrategy {
force 'androidx.metrics:metrics-performance:1.0.0-beta01'
}
}
}
}
Loading