Skip to content

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Sep 2, 2025

What does this PR do?

This PR removes the reporting of fatal errors via Logs. Errors will of course still be reported through RUM.

Motivation

We want to remove fatal errors from logs to avoid duplication.

Additional Notes

Before

Screenshot 2025-09-02 at 10 37 17 Screenshot 2025-09-02 at 10 37 11

After

Screenshot 2025-09-02 at 10 39 31 Screenshot 2025-09-02 at 10 39 35

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio self-assigned this Sep 2, 2025
@sbarrio sbarrio marked this pull request as ready for review September 2, 2025 09:33
@sbarrio sbarrio requested a review from a team as a code owner September 2, 2025 09:33
Copy link
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀 Let's target v3 for this, as discussed :)

@sbarrio sbarrio changed the base branch from develop to feature/v3 September 4, 2025 09:42
@sbarrio sbarrio dismissed marco-saia-datadog’s stale review September 4, 2025 09:42

The base branch was changed.

@sbarrio sbarrio requested a review from a team as a code owner September 4, 2025 09:42
@sbarrio sbarrio changed the base branch from feature/v3 to develop September 4, 2025 09:42
@sbarrio sbarrio removed the request for review from a team September 4, 2025 09:42
@sbarrio sbarrio changed the title [RUM-10518] - Remove fatal errors from Logs [RUM-10518] Remove fatal errors from Logs Sep 4, 2025
@sbarrio sbarrio changed the base branch from develop to feature/v3 September 4, 2025 10:11
@sbarrio sbarrio merged commit 036b4d7 into feature/v3 Sep 17, 2025
10 checks passed
@sbarrio sbarrio deleted the sbarrio/RUM-10518/remove-fatal-errors-from-logs branch September 17, 2025 13:57
@sbarrio sbarrio mentioned this pull request Jan 22, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants