Skip to content

[RUM 11576] [Modularization] Improve module wrapper singleton creation #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marco-saia-datadog merged 1 commit into from
Sep 29, 2025
Merged

[RUM 11576] [Modularization] Improve module wrapper singleton creation #970

marco-saia-datadog merged 1 commit into from
Sep 29, 2025

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Sep 2, 2025

What does this PR do?

This PR improves the way in which we create our Module shared singleton instances to avoid potential collisions and instance regeneration when we start separating the core module into separate packages.

Motivation

This is groundwork for the core modularization effort.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio self-assigned this Sep 2, 2025
@sbarrio sbarrio changed the base branch from develop to feature/v3 September 3, 2025 07:56
@sbarrio sbarrio dismissed marco-saia-datadog’s stale review September 3, 2025 07:56

The base branch was changed.

@sbarrio sbarrio changed the base branch from feature/v3 to develop September 3, 2025 07:56
@sbarrio sbarrio marked this pull request as ready for review September 4, 2025 09:45
@sbarrio sbarrio requested a review from a team as a code owner September 4, 2025 09:45
@sbarrio sbarrio changed the base branch from develop to feature/v3 September 4, 2025 10:05
@sbarrio sbarrio changed the base branch from feature/v3 to develop September 4, 2025 10:11
@sbarrio sbarrio force-pushed the sbarrio/RUM-11576/improve-modular-wrapper-singleton-creation branch from 5365857 to ebe9212 Compare September 8, 2025 10:18
@sbarrio sbarrio force-pushed the sbarrio/RUM-11576/improve-modular-wrapper-singleton-creation branch from ebe9212 to 75212c2 Compare September 8, 2025 11:00
@sbarrio sbarrio changed the base branch from develop to feature/v3 September 22, 2025 14:14
@sbarrio sbarrio dismissed marco-saia-datadog’s stale review September 22, 2025 14:14

The base branch was changed.

@sbarrio sbarrio changed the title [RUM 11576] Improve module wrapper singleton creation [RUM 11576] [Modularization] Improve module wrapper singleton creation Sep 29, 2025
@marco-saia-datadog marco-saia-datadog merged commit 25de515 into feature/v3 Sep 29, 2025
10 checks passed
@marco-saia-datadog marco-saia-datadog deleted the sbarrio/RUM-11576/improve-modular-wrapper-singleton-creation branch September 29, 2025 13:34
@sbarrio sbarrio mentioned this pull request Jan 22, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-saia-datadog marco-saia-datadog marco-saia-datadog approved these changes

Assignees

@sbarrio sbarrio

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbarrio @marco-saia-datadog