Skip to content

[RUM-11612] Fix babel instrumented actions not being buffered and intercepted by actionEventMapper #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdn34dd merged 1 commit into from
Sep 16, 2025
Merged

[RUM-11612] Fix babel instrumented actions not being buffered and intercepted by actionEventMapper #976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/DdSdkReactNative.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ export class DdSdkReactNative {
trackInteractions: configuration.trackInteractions,
useAccessibilityLabel: configuration.useAccessibilityLabel
};

DdBabelInteractionTracking.getInstance(DdRum);
}

if (DdSdkReactNative.wasAutoInstrumented) {
Expand Down
45 changes: 28 additions & 17 deletions packages/core/src/rum/instrumentation/interactionTracking/DdBabelInteractionTracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@
* Copyright 2016-Present Datadog, Inc.
*/

import { InternalLog } from '../../../InternalLog';
import { SdkVerbosity } from '../../../SdkVerbosity';
import DdNativeRum from '../../../specs/NativeDdRum';
import DdSdk from '../../../specs/NativeDdSdk';
import { DefaultTimeProvider } from '../../../utils/time-provider/DefaultTimeProvider';
import type { TimeProvider } from '../../../utils/time-provider/TimeProvider';
import type { DdRum } from '../../DdRum';
import { BABEL_PLUGIN_TELEMETRY } from '../../constants';
import type { RumActionType } from '../../types';
import { ActionSource } from '../../types';
Expand Down Expand Up @@ -46,19 +44,27 @@ export class DdBabelInteractionTracking {

private telemetrySent: boolean = false;

private ddRum: typeof DdRum | null = null;

isInitialized: boolean = false;

private constructor() {
private constructor(ddRum?: typeof DdRum) {
if (DdBabelInteractionTracking.instance) {
throw new Error(StateErrors.ALREADY_INITIALIZED);
}

if (ddRum) {
this.ddRum = ddRum;
}

DdBabelInteractionTracking.instance = this;
}

static getInstance() {
static getInstance(ddRum?: typeof DdRum) {
if (!DdBabelInteractionTracking.instance) {
DdBabelInteractionTracking.instance = new DdBabelInteractionTracking();
DdBabelInteractionTracking.instance = new DdBabelInteractionTracking(
ddRum
);
}

return DdBabelInteractionTracking.instance;
Expand Down Expand Up @@ -150,17 +156,22 @@ export class DdBabelInteractionTracking {
const { trackInteractions } = DdBabelInteractionTracking.config;

if (trackInteractions) {
InternalLog.log(
`Adding RUM Action “${targetName}” (${action}, auto)`,
SdkVerbosity.DEBUG
);

DdNativeRum?.addAction(
action,
targetName,
{ '__dd.action_source': ActionSource.BABEL },
this.timeProvider.now()
);
this.ddRum
?.addAction(
action,
targetName,
{ '__dd.action_source': ActionSource.BABEL },
this.timeProvider.now()
)
.catch(e => {
if (e instanceof Error) {
DdSdk?.telemetryError(
e.message,
e.stack || '',
'BabelActionTrack'
);
}
});
}

return result;
Expand Down
Loading