Skip to content

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Sep 5, 2025

What does this PR do?

This PR makes it so the SDK relies on Datadog.getInstance() to get the native SDK core instance instead of keeping a reference to it inside DatadogSdkWrapperStorage.

Motivation

This is part of the modularization effort being done for v3.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio changed the title [RUM 11204] [Modularization] [Android] Use native SDK's core instance instead of DatadogSdkWrapperStorage's [RUM 11204] [Modularization] Use native SDK's core instance instead of DatadogSdkWrapperStorage's Sep 5, 2025
@sbarrio sbarrio self-assigned this Sep 8, 2025
@marco-saia-datadog
Copy link
Member

Tests are currently failing on Android:

e: file:///Users/ec2-user/builds/JBp7x9hf6/0/DataDog/dd-sdk-reactnative/packages/internal-testing-tools/android/src/test/kotlin/com/datadog/reactnative/internaltesting/DdInternalTestingImplementationTest.kt:75:27 Unresolved reference: Datadog
> Task :compileDebugUnitTestKotlin FAILED
e: file:///Users/ec2-user/builds/JBp7x9hf6/0/DataDog/dd-sdk-reactnative/packages/internal-testing-tools/android/src/test/kotlin/com/datadog/reactnative/internaltesting/DdInternalTestingImplementationTest.kt:75:27 Unresolved reference: Datadog
e: /Users/ec2-user/.gradle/caches/transforms-3/855f9b1d925aa44010257b44e8aa35f7/transformed/react-android-0.76.9-debug/jars/classes.jar!/META-INF/ReactAndroid_debug.kotlin_module: Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.9.0, expected version is 1.6.0.

@sbarrio sbarrio force-pushed the sbarrio/RUM-11204/use-core-sdk-native-instance-on-android branch 4 times, most recently from de03d00 to a91ba58 Compare September 10, 2025 09:31
@sbarrio sbarrio force-pushed the sbarrio/RUM-11204/use-core-sdk-native-instance-on-android branch from a91ba58 to 954d68e Compare September 17, 2025 13:53
@sbarrio sbarrio force-pushed the sbarrio/RUM-11204/use-core-sdk-native-instance-on-android branch from 954d68e to a237cbd Compare September 17, 2025 15:30
@marco-saia-datadog marco-saia-datadog changed the base branch from develop to marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios September 22, 2025 11:18
@marco-saia-datadog marco-saia-datadog changed the base branch from marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios to marcosaia/RUM-11204/use-sdk-default-core-instance September 22, 2025 11:18
@sbarrio sbarrio marked this pull request as ready for review September 22, 2025 14:26
@sbarrio sbarrio requested a review from a team as a code owner September 22, 2025 14:26
@marco-saia-datadog marco-saia-datadog changed the base branch from marcosaia/RUM-11204/use-sdk-default-core-instance to feature/v3 September 22, 2025 15:06
@marco-saia-datadog marco-saia-datadog merged commit 7ee07d3 into feature/v3 Sep 22, 2025
8 checks passed
@marco-saia-datadog marco-saia-datadog deleted the sbarrio/RUM-11204/use-core-sdk-native-instance-on-android branch September 22, 2025 15:07
@sbarrio sbarrio mentioned this pull request Jan 22, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants