Skip to content

Conversation

@marco-saia-datadog
Copy link
Member

@marco-saia-datadog marco-saia-datadog commented Sep 9, 2025

What does this PR do?

Removes the core instance from DatadogSDKWrapper, and refactors the code so that it only relies on the native SDK core instance.

What changed:

  • Removed coreInstance and related methods from DatadogSDKWrapper
  • Refactored onCoreInitializedListener to onSdkInitializedListener
  • Removed wrapper functions from DatadogSDKWrapper now that the coreInstance is no longer necessary, and refactored callers to directly call the native SDK
  • Moved telemetry related functions to new separate class DdTelemetry

TODO

  • Avoid using CoreRegistry.default as it is redundant (?)

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios branch from 60e7f0b to b7a6e5b Compare September 9, 2025 12:46
@marco-saia-datadog marco-saia-datadog self-assigned this Sep 9, 2025
sbarrio
sbarrio previously approved these changes Sep 18, 2025
Copy link
Contributor

@sbarrio sbarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-saia-datadog marco-saia-datadog changed the base branch from develop to feature/v3 September 22, 2025 15:08
@marco-saia-datadog marco-saia-datadog dismissed sbarrio’s stale review September 22, 2025 15:08

The base branch was changed.

@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review September 22, 2025 15:08
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner September 22, 2025 15:08
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios branch from b7a6e5b to 008e733 Compare September 22, 2025 15:14
sbarrio
sbarrio previously approved these changes Sep 22, 2025
@sbarrio sbarrio force-pushed the marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios branch from 008e733 to 93aa612 Compare September 23, 2025 09:14
@marco-saia-datadog marco-saia-datadog merged commit 6c0b11a into feature/v3 Sep 29, 2025
8 checks passed
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-11204/use-core-sdk-native-instance-on-ios branch September 29, 2025 13:34
@sbarrio sbarrio mentioned this pull request Jan 22, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants