fix: glob matching case sensitivity #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure glob matching is case insensitive and add test covering case sensitivity.
BenchmarksBenchmark execution time: 2024-04-13 18:20:34 Comparing candidate commit 74af266 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Anilm3
reviewed
Apr 16, 2024
|
|
||
| while (p < pattern.size() || s < subject.size()) { | ||
| if (p < pattern.size()) { | ||
| const size_t p_size = pattern.size(); |
Contributor
There was a problem hiding this comment.
nit: I can't comment on the relevant line, but instead of using Index = std::size_t; it would make more sense to use using Index = StringView::size_type;, it should work as expected with both absl::string_view and std::string_view. In practice it doesn't make a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure glob matching is case insensitive and add test covering case sensitivity.