Skip to content

Conversation

@dmehala
Copy link
Collaborator

@dmehala dmehala commented Jun 25, 2024

Description

Before merging

  • Assess binary size impact. No increase of binary size.

- Fix crashes on macOS Sonoma:
  curl/curl#11893
- Disable more curl features.
- Debug build do not enable santiizer anymore.
@dmehala dmehala requested a review from a team as a code owner June 25, 2024 18:11
@dmehala dmehala requested review from Anilm3 and pablomartinezbernardo and removed request for a team June 25, 2024 18:11
@pr-commenter
Copy link

pr-commenter bot commented Jun 25, 2024

Benchmarks

Benchmark execution time: 2024-06-28 12:27:14

Comparing candidate commit d3288fe in PR branch dmehala/upgrade-curl-version with baseline commit bb5358e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@dmehala dmehala changed the title deps: bump libcurl to 8.3.0 deps: bump libcurl to 8.8.0 Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (bb5358e) to head (d3288fe).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          71       71           
  Lines        3716     3716           
=======================================
  Hits         3511     3511           
  Misses        205      205           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmehala dmehala merged commit 8112767 into main Jun 28, 2024
@dmehala dmehala deleted the dmehala/upgrade-curl-version branch June 28, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants