Skip to content

Conversation

@dmehala
Copy link
Collaborator

@dmehala dmehala commented Sep 11, 2024

Description

Resolve a regression introduced in #130 where the configuration_change payload didn't adhere to the telemetry schema.

Changes

  • Fix the regression.
  • Validate top-level telemetry schema in unit tests.

Resolve a regression introduced in #130 where the `configuration_change`
payload didn't adhere to the telemetry schema.
@dmehala dmehala requested a review from a team as a code owner September 11, 2024 15:00
@dmehala dmehala requested review from dubloom and pablomartinezbernardo and removed request for a team September 11, 2024 15:01
@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2024

Benchmarks

Benchmark execution time: 2024-09-11 15:02:53

Comparing candidate commit f0f9518 in PR branch dmehala/telemetry/fix-on-change-payload with baseline commit 16cf1eb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (16cf1eb) to head (f0f9518).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files          72       72           
  Lines        3804     3804           
=======================================
  Hits         3601     3601           
  Misses        203      203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmehala dmehala merged commit 67151cf into main Sep 15, 2024
@dmehala dmehala deleted the dmehala/telemetry/fix-on-change-payload branch September 15, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants