fix: telemetry support for sub-seconds intervals #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmehala
requested review from
cataphract and
pablomartinezbernardo
and removed request for
a team
BenchmarksBenchmark execution time: 2024-10-30 20:49:27 Comparing candidate commit b8c1c9e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
dmehala
force-pushed
the
dmehala/fix-telemetry-env-var
branch
from
7c15d40 to
b8c1c9e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
- Coverage 93.95% 93.91% -0.05%
==========================================
Files 73 73
Lines 4170 4175 +5
==========================================
+ Hits 3918 3921 +3
- Misses 252 254 +2 ☔ View full report in Codecov by Sentry. |
pablomartinezbernardo
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
That should solve the failing system tests