-
Notifications
You must be signed in to change notification settings - Fork 15
testing(parametric): update start span parametric endpoint #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2025-01-20 14:02:43 Comparing candidate commit bb55ea9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
418cd3d to
b35ee1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 73 73
Lines 4176 4176
=======================================
Hits 3922 3922
Misses 254 254 ☔ View full report in Codecov by Sentry. |
7316007 to
1484a48
Compare
786889f to
1484a48
Compare
This reverts commit 1484a48.
…t span in another [probably won't work tho]
dmehala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I changed a bit the logic to avoid the endless if/else cascade and documented a bit the change.
Description
/trace/span/start/to a newtrace/span/extract_headersendpoint. This ensures the/trace/span/startparametric endpoint aligns with the following specification./trace/span/finishdoes NOT clear the span list. Spans should only be removed fromspans_(previouslyactive_spans_) if thetrace/spans/flushis called.̶a̶c̶t̶i̶v̶e̶_̶s̶p̶a̶n̶s̶_̶̶ ̶v̶a̶r̶i̶a̶b̶l̶e̶ ̶t̶o̶ ̶̶s̶p̶a̶n̶s̶_̶̶.̶ ̶T̶h̶i̶s̶ ̶m̶a̶p̶ ̶w̶i̶l̶l̶ ̶n̶o̶ ̶l̶o̶n̶g̶e̶r̶ ̶j̶u̶s̶t̶ ̶c̶o̶n̶t̶a̶i̶n̶ ̶a̶c̶t̶i̶v̶e̶ ̶s̶p̶a̶n̶s̶,̶ ̶i̶t̶ ̶w̶i̶l̶l̶ ̶a̶l̶s̶o̶ ̶s̶t̶o̶r̶e̶ ̶s̶p̶a̶n̶s̶ ̶e̶x̶t̶r̶a̶c̶t̶e̶d̶ ̶f̶r̶o̶m̶ ̶d̶i̶s̶t̶r̶i̶b̶u̶t̶e̶d̶ ̶t̶r̶a̶c̶i̶n̶g̶ ̶h̶e̶a̶d̶e̶r̶s̶.̶Motivation
manifest/cpp.yamlthat were introduced in parametric: Ensure start span endpoints align with the spec system-tests#3300Additional Notes
Jira ticket: [PROJ-IDENT]