Skip to content

Properly support setting DD_TRACE_TRANSPORT to "none" #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmehala merged 1 commit into from
Dec 2, 2024
Merged

Properly support setting DD_TRACE_TRANSPORT to "none" #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ endif ()

set(DD_TRACE_TRANSPORT "curl" CACHE STRING "HTTP transport that dd-trace-cpp uses to communicate with the Datadog Agent, can be either 'none' or 'curl'")

if(DD_TRACE_TRANSPORT STREQUAL "curl")
include(cmake/deps/curl.cmake)
message(STATUS "DD_TRACE_TRANSPORT is set to 'curl', including curl")
elseif(DD_TRACE_TRANSPORT STREQUAL "none")
message(STATUS "DD_TRACE_TRANSPORT is set to 'none', no default transport will be included")
else()
message(FATAL_ERROR "Invalid value for DD_TRACE_TRANSPORT: ${DD_TRACE_TRANSPORT}")
endif()

# Consumer of the library using FetchContent do not need
# to build unit tests, fuzzers and examples.
if(CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
Expand All @@ -41,7 +50,6 @@ endif ()

# Linking this library requires threads.
find_package(Threads REQUIRED)
include(cmake/deps/curl.cmake)
include(cmake/deps/json.cmake)
include(cmake/utils.cmake)

Expand Down Expand Up @@ -180,6 +188,11 @@ if (BUILD_SHARED_LIBS)
PRIVATE
CURL::libcurl_shared
)
else()
target_sources(dd_trace_cpp-shared
PRIVATE
src/datadog/default_http_client_null.cpp
)
endif ()

add_dependencies(dd_trace_cpp-shared dd_trace_cpp-objects CURL::libcurl_shared)
Expand Down Expand Up @@ -218,6 +231,11 @@ if (BUILD_STATIC_LIBS)
PRIVATE
CURL::libcurl_static
)
else()
target_sources(dd_trace_cpp-static
PRIVATE
src/datadog/default_http_client_null.cpp
)
endif ()

add_dependencies(dd_trace_cpp-static dd_trace_cpp-objects)
Expand Down