Skip to content

Conversation

@zacharycmontoya
Copy link
Contributor

@zacharycmontoya zacharycmontoya commented Jan 21, 2025

Description

Removes the remote config check that asserts a matching env / service, as this is incorrectly causing remote config payloads to be ignored

Motivation

This was motivated by a customer issue with adaptive sampling not working. When the tracer doesn't report an environment version but the Datadog agent does, incoming remote config payloads (which have already been verified by the Datadog agent) get rejected even though they are correct. This removes the validation and relies upon the Datadog agent verification.

Testing

The previous unit test has been removed as it's invalid, and the associated system-tests authored here have been tested locally with success: DataDog/system-tests#3778

Additional Notes

Jira ticket: APMAPI-1006

@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/fix-remote-config-update branch from 92bb662 to 7bd282c Compare January 24, 2025 17:56
@pr-commenter
Copy link

pr-commenter bot commented Jan 24, 2025

Benchmarks

Benchmark execution time: 2025-01-24 17:59:18

Comparing candidate commit 7bd282c in PR branch zach.montoya/fix-remote-config-update with baseline commit 1a5985e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (1a5985e) to head (7bd282c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   93.82%   93.90%   +0.08%     
==========================================
  Files          73       73              
  Lines        4176     4169       -7     
==========================================
- Hits         3918     3915       -3     
+ Misses        258      254       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@zacharycmontoya zacharycmontoya merged commit 7222d8d into main Jan 24, 2025
21 checks passed
@zacharycmontoya zacharycmontoya deleted the zach.montoya/fix-remote-config-update branch January 24, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants